Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override method only for navigation requests #177

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

elacuesta
Copy link
Member

Fixes #176

Introduced at #144, seems like both checks are necessary.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #177 (07f492f) into main (0cb52d6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #177   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          362       362           
=========================================
  Hits           362       362           
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta force-pushed the override-method-navigation-requests branch from 9fe4fa9 to 07f492f Compare February 17, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overridden method for Playwright request to <URL> original=POST new=GET
2 participants