Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry page.content if necessary #218

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Retry page.content if necessary #218

merged 4 commits into from
Aug 5, 2023

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Aug 3, 2023

Closes #217, closes #186

I wanted to start simple so there's only one retry. This might be a bit naive, perhaps some exponential backoff retrying could be added in the future if this continues to be an issue.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #218 (0a612b4) into main (8a73cf3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines          363       379   +16     
=========================================
+ Hits           363       379   +16     
Files Changed Coverage Δ
scrapy_playwright/_utils.py 100.00% <100.00%> (ø)
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta merged commit d8e41f1 into main Aug 5, 2023
19 checks passed
@elacuesta elacuesta deleted the retry-page-content branch August 5, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant