Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated request_fingerprint with fingerprint in cache and dupefilter files #310

Open
DharmeshPandav opened this issue Feb 6, 2023 · 0 comments

Comments

@DharmeshPandav
Copy link

DharmeshPandav commented Feb 6, 2023

request_fingerprint is deprecated in scrapy 2.7 and is replaced by fingerprint,

Using request_fingerprint results in deprecation warning in logs

https://docs.scrapy.org/en/latest/topics/request-response.html#std-setting-REQUEST_FINGERPRINTER_IMPLEMENTATION

from .dupefilter import splash_request_fingerprint

fp = request_fingerprint(request, include_headers=include_headers)

from .dupefilter import SplashAwareDupeFilter, splash_request_fingerprint

DharmeshPandav added a commit to DharmeshPandav/scrapy-splash that referenced this issue Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant