Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set the default Zyte API Parameters for every Request #12

Closed
BurnzZ opened this issue Apr 29, 2022 · 1 comment · Fixed by #41
Closed

Ability to set the default Zyte API Parameters for every Request #12

BurnzZ opened this issue Apr 29, 2022 · 1 comment · Fixed by #41
Labels
enhancement New feature or request

Comments

@BurnzZ
Copy link
Member

BurnzZ commented Apr 29, 2022 •
edited

Currently, the parameters are passed on a per-request basis.

Users should be able to:

  1. enable Zyte API for all request
  2. set the default parameters for every Zyte API request
@BurnzZ BurnzZ added the enhancement New feature or request label Apr 29, 2022
@BurnzZ BurnzZ mentioned this issue Apr 29, 2022
Merged
@BurnzZ
Copy link
Member Author

BurnzZ commented May 27, 2022

The PR in #13 only partially addresses the points (2) of the issue as it doesn't introduce the mechanism of how to properly enable every scrapy.Request to go through Zyte API without having the need to set the zyte_api param in Request.meta.

There are also things we need to figure out like in the #10 (comment) thread.

@Gallaecio Gallaecio mentioned this issue Aug 12, 2022
Closed
@Gallaecio Gallaecio mentioned this issue Sep 20, 2022
Merged
5 tasks
@kmike kmike closed this as completed in #41 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@BurnzZ