Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating classifiers in setup.py #19

Merged
merged 1 commit into from Aug 24, 2015
Merged

Conversation

eliasdorneles
Copy link
Member

Hey fellows,

This fixes the pre-alpha classifier (see #18) and also add Topic :: Text Processing :: Markup.

We can consider it stable since v1.0, Scrapy is even depending on the current API already.

Also, maybe we could add the more specific Topic :: Text Processing :: Markup :: HTML and Topic :: Text Processing :: Markup :: XML too (see list of classifiers here).

What do you think?

Thanks!

@codecov-io
Copy link

Current coverage is 100.00%

Merging #19 into master will not affect coverage as of e0fcb62

@@            master     #19   diff @@
======================================
  Files            4       4       
  Stmts          194     194       
  Branches        28      28       
  Methods          0       0       
======================================
  Hit            194     194       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of e0fcb62

Powered by Codecov. Updated on successful CI builds.

dangra added a commit that referenced this pull request Aug 24, 2015
@dangra dangra merged commit c6996ba into master Aug 24, 2015
@dangra dangra deleted the update-setup-classifiers branch August 24, 2015 14:12
@kmike
Copy link
Member

kmike commented Aug 24, 2015

Can someone please run python setup.py register to update classifiers on pypi without making a new version?

@eliasdorneles
Copy link
Member Author

@kmike we'll release a 1.0.1 soon, do you think we should still register it for 1.0.0?

@eliasdorneles
Copy link
Member Author

btw, as agreed with @dangra, I added HTML and XML classifiers too: c88d95f

@kmike
Copy link
Member

kmike commented Aug 24, 2015

I just wanted to mention that if the only reason to release 1.0.1 is to get classifiers updated then one can use python setup.py register, without bumping version.

@dangra
Copy link
Member

dangra commented Aug 24, 2015

why not going trough the usual flow of releasing a patch version? it seems natural to me and it doesn't have any disadvantages

@eliasdorneles
Copy link
Member Author

@kmike well, I fixed a typo in HISTORY and I'll also add docstrings to csstranslator.py to help justify the release. =D
sorry guys, I should've been more careful.

@kmike
Copy link
Member

kmike commented Aug 24, 2015

and it doesn't have any disadvantages

One release more means users have to check what is changed one more time, download the package one more time and read one more changelog entry (irrelevant for the user). Not a big deal, but still.

setup.py register only changes what's displayed on pypi website, it doesn't change the tgz/wheel file.

I'll also add docstrings to csstranslator.py

A docstring is a code change, so it can justify a release :)

@dangra
Copy link
Member

dangra commented Aug 24, 2015

One release more means users have to check what is changed one more time, download the package one more time and read one more changelog entry (irrelevant for the user). Not a big deal, but still.

I think it is up to the guy in control of releases, although we will need an emoji for 🚲shedding :)

@kmike
Copy link
Member

kmike commented Aug 24, 2015

My point is that if we know nothing is changed from user's point of view we shouldn't do a release.

+1 to find a right emoji :)

@eliasdorneles
Copy link
Member Author

🚲 ⛺ ?

@kmike
Copy link
Member

kmike commented Aug 24, 2015

👍

@dangra
Copy link
Member

dangra commented Aug 24, 2015

nice one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants