Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectorList.css argument is named 'xpath' #59

Closed
kmike opened this issue Sep 7, 2016 · 3 comments
Closed

SelectorList.css argument is named 'xpath' #59

kmike opened this issue Sep 7, 2016 · 3 comments
Milestone

Comments

@kmike
Copy link
Member

kmike commented Sep 7, 2016

What to you think about renaming SelectorList.css argument to 'query'? It would be a backwards incompatible change, but I doubt there is a lot of code which uses keyword argument for sel.css method.

There is a similar problem in Scrapy.

@redapple
Copy link
Contributor

redapple commented Sep 7, 2016

Makes sense.

@redapple redapple mentioned this issue Nov 15, 2016
4 tasks
@eliasdorneles
Copy link
Member

Is it worth to do it in backwards compatible way? (making both keyword arguments, and add warning if someone use xpath)

Personally, I think it isn't, but...

@kmike
Copy link
Member Author

kmike commented Nov 15, 2016

I also thinks it doesn't worth it, especially in parsel. In Scrapy it is more likely someone used keyword argument, but it still sounds very-very unlikely. Who would write sel.css(xpath='.my-class') in a non-joking way? So +1 for me to do a backwards-incompatible change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants