Skip to content

Commit

Permalink
Drop py34 support
Browse files Browse the repository at this point in the history
  • Loading branch information
elacuesta committed Jul 21, 2019
1 parent b8a4301 commit 40af1b9
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 18 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Expand Up @@ -14,8 +14,6 @@ matrix:
env: TOXENV=pypy
- python: 2.7
env: TOXENV=pypy3
- python: 3.4
env: TOXENV=py34
- python: 3.5
env: TOXENV=py35
- python: 3.6
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Expand Up @@ -40,7 +40,7 @@ https://scrapy.org
Requirements
============

* Python 2.7 or Python 3.4+
* Python 2.7 or Python 3.5+
* Works on Linux, Windows, Mac OSX, BSD

Install
Expand Down
2 changes: 1 addition & 1 deletion docs/faq.rst
Expand Up @@ -69,7 +69,7 @@ Here's an example spider using BeautifulSoup API, with ``lxml`` as the HTML pars
What Python versions does Scrapy support?
-----------------------------------------

Scrapy is supported under Python 2.7 and Python 3.4+
Scrapy is supported under Python 2.7 and Python 3.5+
under CPython (default Python implementation) and PyPy (starting with PyPy 5.9).
Python 2.6 support was dropped starting at Scrapy 0.20.
Python 3 support was added in Scrapy 1.1.
Expand Down
2 changes: 1 addition & 1 deletion docs/intro/install.rst
Expand Up @@ -7,7 +7,7 @@ Installation guide
Installing Scrapy
=================

Scrapy runs on Python 2.7 and Python 3.4 or above
Scrapy runs on Python 2.7 and Python 3.5 or above
under CPython (default Python implementation) and PyPy (starting with PyPy 5.9).

If you're using `Anaconda`_ or `Miniconda`_, you can install the package from
Expand Down
7 changes: 3 additions & 4 deletions setup.py
Expand Up @@ -53,7 +53,6 @@ def has_environment_marker_platform_impl_support():
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
Expand All @@ -63,10 +62,10 @@ def has_environment_marker_platform_impl_support():
'Topic :: Software Development :: Libraries :: Application Frameworks',
'Topic :: Software Development :: Libraries :: Python Modules',
],
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*',
install_requires=[
'Twisted>=13.1.0;python_version!="3.4"',
'Twisted>=13.1.0,<=19.2.0;python_version=="3.4"',
'Twisted>=13.1.0;python_version=="2.7"',
'Twisted>=15.5;python_version>="3.5"',
'w3lib>=1.17.0',
'queuelib',
'lxml',
Expand Down
14 changes: 5 additions & 9 deletions tox.ini
Expand Up @@ -67,30 +67,26 @@ basepython = pypy
commands =
py.test {posargs:scrapy tests}

[testenv:py34]
basepython = python3.4
[testenv:py35]
basepython = python3.5
deps =
-ctests/constraints.txt
-rrequirements-py3.txt
# Extras
Pillow
-rtests/requirements-py3.txt

[testenv:py35]
basepython = python3.5
deps = {[testenv:py34]deps}

[testenv:py36]
basepython = python3.6
deps = {[testenv:py34]deps}
deps = {[testenv:py35]deps}

[testenv:py37]
basepython = python3.7
deps = {[testenv:py34]deps}
deps = {[testenv:py35]deps}

[testenv:pypy3]
basepython = pypy3
deps = {[testenv:py34]deps}
deps = {[testenv:py35]deps}
commands =
py.test {posargs:scrapy tests}

Expand Down

0 comments on commit 40af1b9

Please sign in to comment.