Merge pull request #5977 from scrapy/typing-settings

Typing for scrapy.settings.BaseSettings
scrapy · Jul 24, 2023 · 6e3e3c2 · 6e3e3c2
2 parents 7a1afff + 5e15824
commit 6e3e3c2
Show file tree

Hide file tree

Showing 5 changed files with 147 additions and 57 deletions.
diff --git a/scrapy/crawler.py b/scrapy/crawler.py
@@ -55,7 +55,7 @@ class Crawler:
     def __init__(
         self,
         spidercls: Type[Spider],
-        settings: Union[None, dict, Settings] = None,
+        settings: Union[None, Dict[str, Any], Settings] = None,
         init_reactor: bool = False,
     ):
         if isinstance(spidercls, Spider):