Merge pull request #6290 from Gallaecio/fix-skips

Fix WindowsRunSpiderCommandTest skip outside Windows for older Twisted
scrapy · Mar 12, 2024 · 95a70d3 · 95a70d3
2 parents d7581c6 + e72de11
commit 95a70d3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/tests/test_commands.py b/tests/test_commands.py
@@ -987,10 +987,14 @@ def start_requests(self):
         self.assertIn("The value of FOO is 42", log)
 
 
-@skipIf(platform.system() != "Windows", "Windows required for .pyw files")
 class WindowsRunSpiderCommandTest(RunSpiderCommandTest):
     spider_filename = "myspider.pyw"
 
+    def setUp(self):
+        if platform.system() != "Windows":
+            raise unittest.SkipTest("Windows required for .pyw files")
+        return super().setUp()
+
     def test_start_requests_errors(self):
         log = self.get_log(self.badspider, name="badspider.pyw")
         self.assertIn("start_requests", log)