Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LxmlLinkExtractor unique_list missing key #3273

Closed
nikan1996 opened this issue May 24, 2018 · 0 comments · Fixed by #6221
Closed

LxmlLinkExtractor unique_list missing key #3273

nikan1996 opened this issue May 24, 2018 · 0 comments · Fixed by #6221
Labels
enhancement good first issue

Comments

@nikan1996
Copy link

scrapy/scrapy/linkextractors/lxmlhtml.py

Line 130 in b364d27

return unique_list(all_links)

I think it should behave like

scrapy/scrapy/linkextractors/lxmlhtml.py

Line 91 in b364d27

return unique_list(links, key=self.link_key)

unique the link by its url.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: LxmlLinkExtractor unique_list missing key jxlil/scrapy
2 participants
@Gallaecio @nikan1996