-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LxmlLinkExtractor unique_list missing key #6221
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6221 +/- ##
==========================================
+ Coverage 88.55% 88.60% +0.04%
==========================================
Files 160 161 +1
Lines 11607 11775 +168
Branches 1883 1908 +25
==========================================
+ Hits 10279 10433 +154
- Misses 1003 1011 +8
- Partials 325 331 +6
|
Can you add a test for it? |
I think that in |
If this was properly covered, the tests would have failed before the change. Let me give it a go later on. |
Hi @Gallaecio I see that you added some tests (some were also added here: #6232) Is there something missing that I can help with? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right, I forgot to approve 🤦
cc @wRAR
Oh ok, no problem. Thanks! |
Hi @wRAR , Hope you're doing well. Are any additional changes needed in this PR? Thank you. |
@jxlil this is still in my backlog, I hope to revisit it soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Added
key
argument tounique_list
inLxmlLinkExtractor
Before:
After:
Closes #3273