Use importlib.import_module instead of __import__
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python 2.7, importlib.import_module is the recommended way to
import modules programmatically.
From __import__'s doc:
Import a module. Because this function is meant for use by the
Python
interpreter and not for general use it is better to use
importlib.import_module() to programmatically import a module.
This commit replaces the statements __import__(module) as the previous
replaced the statements __import__(module, {}, {}, ['']).
At first I thought leaving the single-argument calls, but perhaps it's
better to be strict rather than having exceptions to the rule in this
case.
|
Can you check why Travis failed @darkrho ? |
|
@pablohoffman It failed due the removed file requirements-lucid.txt. I did merge latest changes from master and now everything is OK. |
dangra
added a commit
that referenced
this pull request
Nov 7, 2013
Use `importlib.import_module` instead of `__import__`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that python 2.6 support is going to be dropped, the recommended way to import modules is using
importlib.import_moduleas stated in the__import__doc:PD: Sorry for the typo in the second commit!