Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the asyncio warning from coroutines page #4511 #4513

Merged
merged 1 commit into from Apr 27, 2020
Merged

Remove the asyncio warning from coroutines page #4511 #4513

merged 1 commit into from Apr 27, 2020

Conversation

AsheKR
Copy link
Contributor

@AsheKR AsheKR commented Apr 25, 2020

Resolves: #4511

@codecov
Copy link

codecov bot commented Apr 25, 2020 •
edited

Codecov Report

Merging #4513 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4513      +/-   ##
==========================================
- Coverage   84.55%   84.54%   -0.02%     
==========================================
  Files         164      164              
  Lines        9897     9897              
  Branches     1480     1480              
==========================================
- Hits         8368     8367       -1     
  Misses       1261     1261              
- Partials      268      269       +1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 82.85% <0.00%> (-2.86%) ⬇️

kmike
kmike approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gallaecio Gallaecio merged commit c207dbf into scrapy:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike kmike approved these changes

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the asyncio warning from the page about coroutines
4 participants
@AsheKR @kmike @wRAR @Gallaecio