Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission handling on project generation from template files #4666

Merged
merged 5 commits into from
Jul 13, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jul 7, 2020

Fixes #4662, closes #4664

read_only_templates is a copy of the templates folder, where I applied chmod -R -w read-only-templates/.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #4666 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4666      +/-   ##
==========================================
- Coverage   84.80%   84.79%   -0.01%     
==========================================
  Files         163      163              
  Lines        9990     9985       -5     
  Branches     1488     1485       -3     
==========================================
- Hits         8472     8467       -5     
  Misses       1255     1255              
  Partials      263      263              
Impacted Files Coverage Δ
scrapy/commands/startproject.py 100.00% <100.00%> (ø)

@elacuesta elacuesta added this to the v2.2.1 milestone Jul 8, 2020
@wRAR wRAR merged commit 0ebba17 into scrapy:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants