Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feed_options is not passed to build_storage() #4845

Closed
vimagick opened this issue Oct 15, 2020 · 2 comments
Closed

feed_options is not passed to build_storage() #4845

vimagick opened this issue Oct 15, 2020 · 2 comments

Comments

@vimagick
Copy link

def build_instance(builder, *preargs):
return build_storage(builder, uri, preargs=preargs)

I'm not sure.
Maybe we need to pass feed_options parameter to build_storage().

@elacuesta
Copy link
Member

Could you please elaborate?

@GeorgeA92
Copy link
Contributor

@elacuesta
Without feed_options parameter inside build_storage call - Storage objects like FileFeedStorage ignore overwrite -O option mentioned in Scrapy 2.4 relase notes #4857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants