Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest failure #5273

Closed
wRAR opened this issue Oct 12, 2021 · 2 comments · Fixed by #5274
Closed

Doctest failure #5273

wRAR opened this issue Oct 12, 2021 · 2 comments · Fixed by #5274

Comments

@wRAR
Copy link
Member

wRAR commented Oct 12, 2021

Merging #5256 introduced a doctest failure in docs/intro/tutorial.rst:

Expected:
    Traceback (most recent call last):
    File "<console>", line 1, in <module>
    ...
    IndexError: list index out of range
Got:
    Traceback (most recent call last):
      File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/doctest.py", line 1337, in __run
        compileflags, 1), test.globs)
      File "<doctest None[0]>", line 1, in <module>
      File "/home/runner/work/scrapy/scrapy/.tox/py/lib/python3.7/site-packages/parsel/selector.py", line 70, in __getitem__
        o = super(SelectorList, self).__getitem__(pos)
    IndexError: list index out of range
@Gallaecio
Copy link
Member

I think we just need to remove the File "<console>", line 1, in <module> line from the documentation, as it does not (cannot) match the actual output.

@jmherbst
Copy link
Contributor

I'm happy to make this change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants