New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for Spider.update_settings #5846
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5846 +/- ##
==========================================
+ Coverage 88.96% 89.23% +0.26%
==========================================
Files 162 163 +1
Lines 11021 11370 +349
Branches 1797 1844 +47
==========================================
+ Hits 9805 10146 +341
+ Misses 938 930 -8
- Partials 278 294 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my points below, I think it may be good to highlight the benefits of update_settings over custom_settings. I‘m thinking that the main one is that you can dynamically add, remove or change settings based on spider arguments and other settings that may be defined outside code (e.g. Scrapy Cloud settings), not sure if there are others.
Done. The requested modifications were made and the last paragraph was replaced to highlight the benefits of |
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
It doesn't cover everything that I want to be covered here, I'll try to suggest some additional wording. |
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Thanks! |
Added documentation for the
Spider.update_settings
class method.Fixes #5745, closes #5757, closes #5784.