Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(): use OSError exception #6198

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 5, 2024

os.error is an alias of the preferable OSError.

Reference

https://docs.astral.sh/ruff/rules/os-error-alias/

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #6198 (42c481c) into master (40e623b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6198      +/-   ##
==========================================
- Coverage   88.63%   88.63%   -0.01%     
==========================================
  Files         160      160              
  Lines       11615    11614       -1     
  Branches     1890     1890              
==========================================
- Hits        10295    10294       -1     
  Misses        994      994              
  Partials      326      326              
Files Coverage Δ
scrapy/pipelines/files.py 79.26% <100.00%> (-0.07%) ⬇️

@kmike kmike merged commit 8251373 into scrapy:master Jan 11, 2024
26 checks passed
@kmike
Copy link
Member

kmike commented Jan 11, 2024

👍

@Rotzbua Rotzbua deleted the refactor_exception branch January 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants