[backport][1.1] Use best practices for TLS connections when using Twisted>=14.0 #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement IPolicyForHTTPS Backward compatibility for HTTP/10 context factory New DOWNLOADER_CLIENT_TLS_METHOD setting to configure TLS method Backward-compatibility for common Scrapy context factory patterns Add warning for context factories not accepting `method` param Use context factory class name in warning message
Current coverage is
|
redapple
added a commit
that referenced
this pull request
Feb 24, 2016
[backport][1.1] Use best practices for TLS connections when using Twisted>=14.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting (squashed commits from) #1794 into 1.1
Implement IPolicyForHTTPS
Backward compatibility for HTTP/10 context factory
New DOWNLOADER_CLIENT_TLS_METHOD setting to configure TLS method
Backward-compatibility for common Scrapy context factory patterns
Add warning for context factories not accepting
methodparamUse context factory class name in warning message