[WIP] adding LOG_FILEMODE settings for enabling mode in logging FileHandler #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 83.45% (diff: 66.66%)@@ master #2494 diff @@
==========================================
Files 161 161
Lines 8780 8782 +2
Methods 0 0
Messages 0 0
Branches 1288 1288
==========================================
+ Hits 7327 7329 +2
Misses 1205 1205
Partials 248 248
|
|
@redapple any idea here? would that be ok to create a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been seeing a lot of questions on Stackoverflow related to controlling more the scrapy logs. One in particular is the ability to rewrite the logs in the same file, which would be easily handled with this improvement by adding
LOG_FILEMODE='w'in settings.This is still WIP, so if you agree with this improvement I will continue working on it (add documentation, tests, etc.)
Another possibility I was thinking is to add the ability to override an entire LogHandler (just like
DUPEFILTER_CLASS), that way there would be more control over it, as we currently only supportFileHandler,StreamHandlerandNullHandler.Please let me know what do you think.