[MRG+1] Allow dropping field in from_response formdata #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisonGregg
changed the title
HarrisonGregg
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 162 162
Lines 9155 9155
Branches 1358 1359 +1
=======================================
Hits 7759 7759
Misses 1145 1145
Partials 251 251
Continue to review full report at Codecov.
|
dangra
requested changes
May 15, 2017
scrapy/http/request/form.py
Outdated
| @@ -135,7 +135,7 @@ def _get_inputs(form, formdata, dont_click, clickdata, response): | |||
| if clickable and clickable[0] not in formdata and not clickable[0] is None: | |||
| values.append(clickable) | |||
|
|
|||
| values.extend(formdata.items()) | |||
| values.extend([(k, v) for k, v in formdata.items() if v is not None]) | |||
There was a problem hiding this comment.
no need to build an intermediate list. Just use:
values.extend((k, v) for k, v in formdata.items() if v is not None)
There was a problem hiding this comment.
I didn't realize you could do that. Thanks! Would you prefer if I squashed this into the other commit on this file?
|
Nice to have feature, simple implementation and good test case. thanks @HarrisonGregg |
|
Yes, please.
El lun., 15 de may. de 2017 12:28, Harrison <notifications@github.com>
escribió:
… ***@***.**** commented on this pull request.
------------------------------
In scrapy/http/request/form.py
<#2721 (comment)>:
> @@ -135,7 +135,7 @@ def _get_inputs(form, formdata, dont_click, clickdata, response):
if clickable and clickable[0] not in formdata and not clickable[0] is None:
values.append(clickable)
- values.extend(formdata.items())
+ values.extend([(k, v) for k, v in formdata.items() if v is not None])
I didn't realize you could do that. Thanks! Would you prefer if I squashed
this into the other commit on this file?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2721 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACR-cHifvKPMXSQnRv2Ehgr68khgrpTks5r6G80gaJpZM4NMuw5>
.
|
HarrisonGregg
force-pushed
the
feature-drop-from-response-field
branch
from
313f157
to
ffef828
Compare
|
@dangra Squashed. |
dangra
approved these changes
May 15, 2017
dangra
changed the title
|
@redapple I think this is ready to go. Is it still in time for 1.4.0? |
redapple
approved these changes
May 16, 2017
|
@dangra , alright, lets include it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #667.
FormRequest.from_responseis very helpful, but sometimes it includes a field that you would like to remove. With this change, you can include a field with valueNoneinformdatawhen callingfrom_response, and the field will be omitted from the body of the returned request.