Allow configuring url escaping on Request objects. #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on py27 and py36 (twisted 17.9.0). |
|
@dyeray Problem with unit-tests was fixed in master. Can you merge master to this PR? |
dyeray
force-pushed
the
833-prevent_url_encoding
branch
from
37e1433
to
7100a1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3255 +/- ##
==========================================
+ Coverage 82.12% 82.13% +0.01%
==========================================
Files 228 228
Lines 9599 9606 +7
Branches 1385 1385
==========================================
+ Hits 7883 7890 +7
Misses 1457 1457
Partials 259 259
|
dyeray
force-pushed
the
833-prevent_url_encoding
branch
from
7100a1a
to
4e7224f
Compare
|
Done. |
|
Implements #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a boolean parameter "escape_url" on the Request constructor that indicates whether the url will be escaped or left as it is. This parameter is saved on the request object so a new request object can be built from the previous one using the replace method.
Fixes #833