Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An interface to customize download scheme for other download handlers #3360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

An interface to customize download scheme for other download handlers #3360

wants to merge 1 commit into from

Conversation

dingld
Copy link

@dingld dingld commented Aug 2, 2018

A little modification is made on the interface to parse download scheme, scrapy.core.downloader.handler, making it more friendly to add customized download handlers.
Say, when you want to handle the http request via a render engine, without hacking the native download middleware.

Resolves #3354

@dingld dingld changed the title An interface to customize download scheme for other download handlers #3354 An interface to customize download scheme for other download handlers Aug 2, 2018
@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #3360 into master will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
- Coverage   84.34%   84.32%   -0.03%     
==========================================
  Files         167      167              
  Lines        9359     9365       +6     
  Branches     1388     1390       +2     
==========================================
+ Hits         7894     7897       +3     
- Misses       1209     1211       +2     
- Partials      256      257       +1
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/__init__.py 75% <42.85%> (-5%) ⬇️
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize schemes for download handlers.
1 participant