Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the structure of
SitemapSpider
makes extraction of additional data from a sitemap unnecessarily complicated.It would require copy-pasting the 22-line
_parse_sitemap
method, and then processing the created sitemap in a for loop.This PR splits
_parse_sitemap
functionality into 3 additional methods, making this kind of processing simpler.It also moves the link extraction inside the spider.
I also added tests for some of the previously untested
SitemapSpider
functionality.