Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed BOT_NAME documentation #4081

Merged
merged 2 commits into from Oct 16, 2019
Merged

Fixed BOT_NAME documentation #4081

merged 2 commits into from Oct 16, 2019

Conversation

bulatbulat48
Copy link
Contributor

@bulatbulat48 bulatbulat48 commented Oct 16, 2019 •
edited by Gallaecio

Fixes #4072

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #4081 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4081   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         165      165           
  Lines        9734     9734           
  Branches     1463     1463           
=======================================
  Hits         8341     8341           
  Misses       1136     1136           
  Partials      257      257

wRAR
wRAR reviewed Oct 16, 2019
View reviewed changes
docs/topics/settings.rst Outdated
@@ -229,8 +229,7 @@ BOT_NAME
Default: ``'scrapybot'``

The name of the bot implemented by this Scrapy project (also known as the
project name). This will be used to construct the User-Agent by default, and
also for logging.
project name) and also for logging.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it now reads "The name of the bot implemented by this Scrapy project (also known as the project name) and also for logging."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the bot implemented by this Scrapy project (also known as the project name). This name will be used for the logging too.
is it need to rewrite like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better.

@bulatbulat48 bulatbulat48 reopened this Oct 16, 2019
@wRAR wRAR merged commit 4894437 into scrapy:master Oct 16, 2019
@Gallaecio Gallaecio mentioned this pull request Oct 16, 2019
Closed
@bulatbulat48 bulatbulat48 deleted the documentation-botname branch October 16, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BOT_NAME and the user agent
3 participants
@bulatbulat48 @wRAR @Gallaecio