Drop the conditional code for old Twisted. #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4820 +/- ##
==========================================
+ Coverage 87.52% 87.55% +0.03%
==========================================
Files 160 160
Lines 9761 9756 -5
Branches 1440 1439 -1
==========================================
- Hits 8543 8542 -1
+ Misses 955 953 -2
+ Partials 263 261 -2
|
Gallaecio
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to not deprecate
set_tlsext_host_nameas I doubt anybody used it.Note that this is the only use of
scrapy.twisted_version, but we may want to use it in the future and we definitely will need to deprecate it before removing, so I kept it.