Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the libxml2 version in CI as a newer one breaks lxml. #5208

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Jul 16, 2021

@wRAR wRAR added the CI label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #5208 (2f5048d) into master (89b654b) will increase coverage by 0.39%.
The diff coverage is n/a.

❗ Current head 2f5048d differs from pull request most recent head 0d36cbb. Consider uploading reports for the commit 0d36cbb to get more accurate results

@@            Coverage Diff             @@
##           master    #5208      +/-   ##
==========================================
+ Coverage   88.00%   88.40%   +0.39%     
==========================================
  Files         162      162              
  Lines       10526    10526              
  Branches     1522     1522              
==========================================
+ Hits         9263     9305      +42     
+ Misses        985      946      -39     
+ Partials      278      275       -3     
Impacted Files Coverage Δ
scrapy/core/http2/protocol.py 83.41% <0.00%> (+0.50%) ⬆️
scrapy/crawler.py 88.26% <0.00%> (+1.11%) ⬆️
scrapy/core/scraper.py 87.86% <0.00%> (+2.31%) ⬆️
scrapy/extensions/feedexport.py 95.03% <0.00%> (+3.97%) ⬆️
scrapy/squeues.py 100.00% <0.00%> (+4.65%) ⬆️
scrapy/utils/reactor.py 81.66% <0.00%> (+6.66%) ⬆️
scrapy/utils/test.py 60.93% <0.00%> (+10.93%) ⬆️
scrapy/utils/asyncgen.py 100.00% <0.00%> (+16.66%) ⬆️
scrapy/utils/ssl.py 70.73% <0.00%> (+17.07%) ⬆️

@Gallaecio Gallaecio merged commit ee2df97 into scrapy:master Jul 16, 2021
Gallaecio pushed a commit to Gallaecio/scrapy that referenced this pull request Oct 5, 2021
@wRAR wRAR deleted the tests-36-selectors branch May 8, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants