Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'callback' key in keyword arguments for request callbacks #5251

Merged

Conversation

elacuesta
Copy link
Member

Fixes #5237

Use Deferred.addCallbacks instead of Deferred.addCallback. Modified the test case to work with this patch but fail with the current code in master.

@elacuesta
Copy link
Member Author

The failed pylint check is because of the f-strings, being worked on at #5246.

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #5251 (9d3e7fb) into master (7d557f8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9d3e7fb differs from pull request most recent head 67cf329. Consider uploading reports for the commit 67cf329 to get more accurate results

@@           Coverage Diff           @@
##           master    #5251   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         163      163           
  Lines       10592    10592           
  Branches     1524     1524           
=======================================
  Hits         9375     9375           
  Misses        943      943           
  Partials      274      274           
Impacted Files Coverage Δ
scrapy/core/scraper.py 87.86% <100.00%> (ø)

@Gallaecio Gallaecio merged commit 890f884 into scrapy:master Oct 1, 2021
@elacuesta elacuesta deleted the request-keyword-arguments-callback branch October 1, 2021 13:52
@GeorgeA92 GeorgeA92 mentioned this pull request Oct 1, 2021
@elacuesta elacuesta mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrapy > 2.3 prevents passing callback in cb_kwargs
2 participants