Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CodeBlockParser has been renamed to PythonCodeBlockParser #5299

Merged
merged 1 commit into from
Nov 4, 2021
Merged

fix: CodeBlockParser has been renamed to PythonCodeBlockParser #5299

merged 1 commit into from
Nov 4, 2021

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented Oct 27, 2021

fixes #5298

@wRAR
Copy link
Member

wRAR commented Oct 27, 2021

This will break with old Sybil.

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #5299 (ecf1482) into master (3225de7) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head ecf1482 differs from pull request most recent head 67994d1. Consider uploading reports for the commit 67994d1 to get more accurate results

@@            Coverage Diff             @@
##           master    #5299      +/-   ##
==========================================
- Coverage   88.53%   88.36%   -0.17%     
==========================================
  Files         163      163              
  Lines       10616    10616              
  Branches     1558     1558              
==========================================
- Hits         9399     9381      -18     
- Misses        942      960      +18     
  Partials      275      275              
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️

@azzamsa
Copy link
Contributor Author

azzamsa commented Oct 27, 2021

I have updated the code to handle old Sybil version.
Taken from @Gallaecio repo

@Gallaecio
Copy link
Member

Shall we pint to >=3,<4, and just switch the code to the new way? (it seems to follow semantic versioning, so we should be safe with that range)

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m OK with this fix, but I also think that we don’t need backward compatibility for a test-only dependency like this. I would just make the change for the 3.0 API, and possibly cap to >=3,<4.

@azzamsa
Copy link
Contributor Author

azzamsa commented Nov 2, 2021

Any update about this PR?
Thanks.

@wRAR wRAR merged commit ed50a81 into scrapy:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing with new Sybil
3 participants