Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logformatter_adapter - do not return args if not provided #5572

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jedmonson
Copy link

@jedmonson jedmonson commented Jul 22, 2022

This change corrects an issue where args are passed to logging.log no matter what Falsy-evaluated value is passed as the args.

Fixes #5570

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #5572 (5c8445e) into master (f60c7ae) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5572      +/-   ##
==========================================
+ Coverage   88.68%   88.72%   +0.03%     
==========================================
  Files         162      162              
  Lines       10774    10774              
  Branches     1844     1844              
==========================================
+ Hits         9555     9559       +4     
+ Misses        945      943       -2     
+ Partials      274      272       -2     
Impacted Files Coverage Δ
scrapy/utils/log.py 93.68% <100.00%> (+4.21%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrapy.utils.log.logformatter_adapter - returns fixed tuple
1 participant