Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial in is_generator_with_return_value #5599

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Partial in is_generator_with_return_value #5599

merged 3 commits into from
Oct 31, 2022

Conversation

tonal
Copy link
Contributor

@tonal tonal commented Aug 16, 2022

See path in #5592

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #5599 (257e44a) into master (b394f21) will increase coverage by 5.27%.
The diff coverage is 83.33%.

❗ Current head 257e44a differs from pull request most recent head b71d029. Consider uploading reports for the commit b71d029 to get more accurate results

@@            Coverage Diff             @@
##           master    #5599      +/-   ##
==========================================
+ Coverage   83.39%   88.67%   +5.27%     
==========================================
  Files         162      162              
  Lines       10998    11007       +9     
  Branches     1799     1801       +2     
==========================================
+ Hits         9172     9760     +588     
+ Misses       1561      966     -595     
- Partials      265      281      +16     
Impacted Files Coverage Δ
scrapy/utils/reactor.py 81.57% <62.50%> (+2.12%) ⬆️
scrapy/utils/defer.py 97.33% <100.00%> (+0.03%) ⬆️
scrapy/utils/misc.py 97.87% <100.00%> (+0.06%) ⬆️
scrapy/utils/python.py 88.46% <0.00%> (ø)
scrapy/commands/check.py 71.01% <0.00%> (ø)
scrapy/shell.py 68.75% <0.00%> (+0.78%) ⬆️
scrapy/core/downloader/handlers/http11.py 94.09% <0.00%> (+0.98%) ⬆️
scrapy/extensions/feedexport.py 95.12% <0.00%> (+3.89%) ⬆️
scrapy/squeues.py 100.00% <0.00%> (+4.65%) ⬆️
scrapy/pipelines/media.py 98.58% <0.00%> (+5.67%) ⬆️
... and 7 more

@wRAR
Copy link
Member

wRAR commented Oct 20, 2022

Can you please merge master so that unrelated test failures are removed? Thanks.

@wRAR
Copy link
Member

wRAR commented Oct 27, 2022

This also needs a test, I can work on it later.

@wRAR wRAR requested review from elacuesta and Gallaecio October 31, 2022 10:09
@wRAR wRAR merged commit a95a338 into scrapy:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError module, class, method, function, traceback, frame, or code object was expected, got partial
3 participants