Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #5819 -- Bug of parse command #5824

Merged
merged 6 commits into from Mar 10, 2023
Merged

Conversation

mtabbasi
Copy link
Contributor

@mtabbasi mtabbasi commented Feb 2, 2023

Fixes #5819

@mtabbasi mtabbasi marked this pull request as ready for review February 4, 2023 08:29
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #5824 (c11d8a9) into master (874a879) will decrease coverage by 0.06%.
The diff coverage is 85.22%.

❗ Current head c11d8a9 differs from pull request most recent head 0ceebdf. Consider uploading reports for the commit 0ceebdf to get more accurate results

@@            Coverage Diff             @@
##           master    #5824      +/-   ##
==========================================
- Coverage   88.94%   88.88%   -0.06%     
==========================================
  Files         162      162              
  Lines       11002    11033      +31     
  Branches     1798     1798              
==========================================
+ Hits         9786     9807      +21     
- Misses        937      948      +11     
+ Partials      279      278       -1     
Impacted Files Coverage Δ
scrapy/commands/parse.py 29.26% <42.10%> (+1.07%) ⬆️
scrapy/core/http2/agent.py 96.42% <83.33%> (+0.04%) ⬆️
scrapy/core/http2/protocol.py 83.49% <85.71%> (+0.07%) ⬆️
scrapy/core/downloader/__init__.py 92.48% <100.00%> (ø)
scrapy/core/engine.py 84.19% <100.00%> (+0.17%) ⬆️
scrapy/core/http2/stream.py 91.90% <100.00%> (ø)
scrapy/core/scraper.py 84.61% <100.00%> (+0.08%) ⬆️
scrapy/core/spidermw.py 99.44% <100.00%> (ø)
scrapy/http/request/form.py 96.15% <100.00%> (+0.66%) ⬆️
scrapy/pipelines/files.py 71.90% <100.00%> (+0.47%) ⬆️
... and 3 more

@wRAR wRAR closed this Feb 14, 2023
@wRAR wRAR reopened this Feb 14, 2023
@wRAR wRAR marked this pull request as draft March 4, 2023 17:10
@mtabbasi mtabbasi marked this pull request as ready for review March 4, 2023 18:57
@mtabbasi mtabbasi marked this pull request as draft March 4, 2023 18:59
@mtabbasi mtabbasi marked this pull request as ready for review March 4, 2023 19:00
Copy link
Contributor

@emarondan emarondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed solution tested and working. it looks good to me.

@Gallaecio Gallaecio merged commit afafc27 into scrapy:master Mar 10, 2023
@Gallaecio
Copy link
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrapy parse doesn't support async callbacks with yield
4 participants