Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5970 #6082

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #5970 #6082

wants to merge 4 commits into from

Conversation

buungoo
Copy link

@buungoo buungoo commented Oct 2, 2023 •
edited by wRAR

Logs a warning as specified in issue #5970

Fixes #5970

@wRAR
Copy link
Member

wRAR commented Oct 2, 2023

  1. This needs a test.
  2. I think crawl is not the only command where it makes sense.
  3. There should be no need to check EXTENSIONS_BASE, you should use settings.getwithbase("EXTENSIONS") to get the final setting value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit a warning if options -o or -O are specified when FeedExporter is disabled
2 participants
@buungoo @wRAR