issue#6305 Replace deprecated ast.NameConstant usage and add tests #6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
reviewed
Apr 3, 2024
| @@ -2,6 +2,7 @@ | |||
| import warnings | |||
| from functools import partial | |||
| from unittest import mock | |||
| import ast | |||
There was a problem hiding this comment.
It shouldn't be used in tests directly.
There was a problem hiding this comment.
Hiya! Good call out -- I amended my commit to use magic mock. Let me know what you think. Cheers.
wRAR
reviewed
Apr 4, 2024
| @@ -12,6 +12,13 @@ | |||
| def _indentation_error(*args, **kwargs): | |||
| raise IndentationError() | |||
|
|
|||
| def create_ast_return(value=None): | |||
| return ( | |||
| unittest.mock.MagicMock(name='ast.Return', value=None) | |||
There was a problem hiding this comment.
Hmm my point is that I expect this test to test real code that produces specific ast nodes when parsed.
There was a problem hiding this comment.
Yes, that makes sense. I will push a new change tomorrow. Thank you for the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Within
misc.pythere is a usage ofast.NameConstant.ast.NameConstantwill be deprecated beginning with Python 3.14.x so we want to remove it.Solution
ast.NameConstantwithast.Constantwithinmisc.pyast.Constantwith a value, or with aNonevalueValidation
Fixes #6305