Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to most Deferred in scrapy/core. #6395

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Jun 8, 2024

No description provided.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (feb0b8f) to head (52f9e32).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6395       +/-   ##
===========================================
+ Coverage   43.98%   89.47%   +45.48%     
===========================================
  Files         162      162               
  Lines       12183    12235       +52     
  Branches     1730     1854      +124     
===========================================
+ Hits         5359    10947     +5588     
+ Misses       6447      971     -5476     
+ Partials      377      317       -60     
Files Coverage Δ
scrapy/core/downloader/__init__.py 92.10% <100.00%> (+12.77%) ⬆️
scrapy/core/downloader/handlers/ftp.py 98.63% <100.00%> (+47.94%) ⬆️
scrapy/core/downloader/handlers/http10.py 100.00% <100.00%> (+48.27%) ⬆️
scrapy/core/downloader/handlers/http11.py 94.40% <100.00%> (+36.26%) ⬆️
scrapy/core/downloader/handlers/http2.py 100.00% <100.00%> (+100.00%) ⬆️
scrapy/core/downloader/handlers/s3.py 94.64% <100.00%> (+0.09%) ⬆️
scrapy/core/downloader/middleware.py 96.82% <100.00%> (+30.69%) ⬆️
scrapy/core/downloader/webclient.py 94.77% <100.00%> (+64.17%) ⬆️
scrapy/core/scheduler.py 93.52% <100.00%> (+30.93%) ⬆️
scrapy/core/scraper.py 86.38% <100.00%> (+23.62%) ⬆️
... and 5 more

... and 129 files with indirect coverage changes

@Gallaecio Gallaecio merged commit 1282ddf into scrapy:master Jun 10, 2024
27 checks passed
@wRAR wRAR deleted the typing-deferred-core branch June 10, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants