-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for a centos rpm package of ScrapyD #30
Conversation
@@ -0,0 +1,31 @@ | |||
RPM build documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reStructuredText is the preferred syntax for documentation (the README and scrapy docs are all written in ReST). Can we keep that convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done with 5f968ac
I left a few comments. Building a RPM for Scrapyd turns our to be a lo more work than what is proposed in this pull request, I'm afraid. To make a proper RPM, the package should declare its dependencies (twisted, scrapy, etc). Those present in CentOS (either main distro or through extras) should be used (like "python-twisted", if there's one) and the ones not present (scrapy) a RPM should be made by ourselves (that'd mean, building a RPM of Scrapy as well). It's a different approach than what this pull request has taken, but the proper way to do it, and the only clean one that I would like to see being merged to Scrapyd repo. I would like to hear others' opinion on the topic, @dangra what do you think? |
Without proper dependency on an Scrapy rpm I don't see this scrapyd rpm going anywhere. also, shouldn't the service be supervised by systemd instead of upstart on CentOS? |
Again, as explained before, the only dependency is scrapy (since scrapy already requires twisted, it isn't necessary to require it for scrapyd as well, it will come along the scrapy install). Regarding upstart, this is an el6 rpm, so for CentOS6, which comes with upstart, no need of SysV. |
I still do not really understand the reasons this was not pulled : the two concerns were on the use of upstart which as explained is fine with CentOS 6+, and on the dependencies, which are all adressed when installing scrapyd already, which can be done via pip and says so in the rpm installer. Did you guys make any progress on building a dedicated rpm for Scrapy maybe? |
Linux-flavor-specific configuration is no longer tracked in this repository. #439 Also, deployment is quite simple without packaging. #258 (comment) |
Repropose the pull request #29 without the undesired commit and with an improved postinstall test on whether scrapyd is well running.