Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for a centos rpm package of ScrapyD #30

Closed
wants to merge 6 commits into from

Conversation

boogheta
Copy link

@boogheta boogheta commented Dec 2, 2013

Repropose the pull request #29 without the undesired commit and with an improved postinstall test on whether scrapyd is well running.

@@ -0,0 +1,31 @@
RPM build documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reStructuredText is the preferred syntax for documentation (the README and scrapy docs are all written in ReST). Can we keep that convention?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with 5f968ac

@pablohoffman
Copy link
Member

I left a few comments.

Building a RPM for Scrapyd turns our to be a lo more work than what is proposed in this pull request, I'm afraid. To make a proper RPM, the package should declare its dependencies (twisted, scrapy, etc). Those present in CentOS (either main distro or through extras) should be used (like "python-twisted", if there's one) and the ones not present (scrapy) a RPM should be made by ourselves (that'd mean, building a RPM of Scrapy as well).

It's a different approach than what this pull request has taken, but the proper way to do it, and the only clean one that I would like to see being merged to Scrapyd repo.

I would like to hear others' opinion on the topic, @dangra what do you think?

@dangra
Copy link
Member

dangra commented Dec 2, 2013

Without proper dependency on an Scrapy rpm I don't see this scrapyd rpm going anywhere.

also, shouldn't the service be supervised by systemd instead of upstart on CentOS?

@boogheta
Copy link
Author

boogheta commented Dec 3, 2013

Again, as explained before, the only dependency is scrapy (since scrapy already requires twisted, it isn't necessary to require it for scrapyd as well, it will come along the scrapy install).
If a scrapy rpm package were to be done, adding it as a dependency would indeed be the way to go.
In the mean time, the package complains when it is missing and tells you how to do it (pip install at the moment, which does not seem like possible to add as dependency in the rpm).
Right now we already spent a lot too much time on this than what we can afford, and we will use this temporary package. Maybe we can spend again some time to make a scrapy package later next year.

Regarding upstart, this is an el6 rpm, so for CentOS6, which comes with upstart, no need of SysV.

@boogheta
Copy link
Author

boogheta commented Mar 2, 2015

I still do not really understand the reasons this was not pulled : the two concerns were on the use of upstart which as explained is fine with CentOS 6+, and on the dependencies, which are all adressed when installing scrapyd already, which can be done via pip and says so in the rpm installer. Did you guys make any progress on building a dedicated rpm for Scrapy maybe?

@jpmckinney
Copy link
Contributor

Linux-flavor-specific configuration is no longer tracked in this repository. #439

Also, deployment is quite simple without packaging. #258 (comment)

@jpmckinney jpmckinney closed this May 13, 2022
@jpmckinney jpmckinney added pr: abandoned for unmerged PRs that were abandoned status: wontfix and removed topic: deployment pr: abandoned for unmerged PRs that were abandoned labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants