-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Schedule' buttons in the Jobs page #321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 68.37% 67.91% -0.46%
==========================================
Files 16 16
Lines 819 826 +7
Branches 96 98 +2
==========================================
+ Hits 560 561 +1
- Misses 230 236 +6
Partials 29 29
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 68.37% 67.91% -0.46%
==========================================
Files 16 16
Lines 819 826 +7
Branches 96 98 +2
==========================================
+ Hits 560 561 +1
- Misses 230 236 +6
Partials 29 29
Continue to review full report at Codecov.
|
@Digenis, What do you think about the added 'Schedule' button? |
There's no way to add arguments and settings The reason I wrote the cancel shortcut is that the solution suits any user. If we add a form to add arguments, we are getting in to the scope of other tools |
Not every spider run needs arguments and settings from cmd. PS: typo for scrapydweb |
I share the concerns of @Digenis in #321 (comment) Edit: Also, it's a bit odd to only be able to schedule spiders that have finished jobs. I would expect the UI to then also allow scheduling any spider in any project. Better not to create that user expectation, if we don't intend to fulfill it. |
This PR adds a schedule endpoint based on #256.
Note that the 'Cancel' and the 'Schedule' buttons still not visible
in Python 3 due to #312.