Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Schedule' buttons in the Jobs page #321

Closed
wants to merge 1 commit into from
Closed

Add 'Schedule' buttons in the Jobs page #321

wants to merge 1 commit into from

Conversation

my8100
Copy link
Collaborator

@my8100 my8100 commented Apr 20, 2019

This PR adds a schedule endpoint based on #256.
Note that the 'Cancel' and the 'Schedule' buttons still not visible
in Python 3 due to #312.

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #321 into master will decrease coverage by 0.45%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   68.37%   67.91%   -0.46%     
==========================================
  Files          16       16              
  Lines         819      826       +7     
  Branches       96       98       +2     
==========================================
+ Hits          560      561       +1     
- Misses        230      236       +6     
  Partials       29       29
Impacted Files Coverage Δ
scrapyd/website.py 56.43% <11.11%> (-3.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5298f9b...c0a9b06. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #321 into master will decrease coverage by 0.45%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   68.37%   67.91%   -0.46%     
==========================================
  Files          16       16              
  Lines         819      826       +7     
  Branches       96       98       +2     
==========================================
+ Hits          560      561       +1     
- Misses        230      236       +6     
  Partials       29       29
Impacted Files Coverage Δ
scrapyd/website.py 56.43% <11.11%> (-3.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5298f9b...c0a9b06. Read the comment docs.

@my8100
Copy link
Collaborator Author

my8100 commented Apr 21, 2019

@Digenis, What do you think about the added 'Schedule' button?

@Digenis
Copy link
Member

Digenis commented Apr 22, 2019

There's no way to add arguments and settings
and, taken from the finished jobs,
it creates the confusion that the job will run with the same arguments.

The reason I wrote the cancel shortcut is that the solution suits any user.

If we add a form to add arguments, we are getting in to the scope of other tools
such as scrapyweb. What do you think?

@my8100
Copy link
Collaborator Author

my8100 commented Apr 22, 2019

Not every spider run needs arguments and settings from cmd.
And it's convenient for repeating crawling jobs with just a click.

PS: typo for scrapydweb

@jpmckinney
Copy link
Contributor

jpmckinney commented Sep 24, 2021

I share the concerns of @Digenis in #321 (comment)

Edit: Also, it's a bit odd to only be able to schedule spiders that have finished jobs. I would expect the UI to then also allow scheduling any spider in any project. Better not to create that user expectation, if we don't intend to fulfill it.

@jpmckinney jpmckinney closed this Feb 2, 2023
@jpmckinney jpmckinney added status: wontfix status: invalid not a Scrapyd issue, an accidental PR or an improper approach and removed status: wontfix labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid not a Scrapyd issue, an accidental PR or an improper approach
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants