Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow remote items store #48

Merged
merged 5 commits into from Jun 20, 2014

Conversation

mgregson
Copy link
Contributor

Sometimes it's convenient to allow storage of item feeds somewhere other than local disk (ie, S3). Scrapy allows this but the current scrapyd handling of FEED_URI blocks the feature. This should allow passing non-file URI schemes through to scrapy without losing existing functionality when provided a file-scheme URI or a raw path.

pablohoffman added a commit that referenced this pull request Jun 20, 2014
@pablohoffman pablohoffman merged commit a152e88 into scrapy:master Jun 20, 2014
@pablohoffman
Copy link
Member

Thanks for the useful contribution @mgregson, and sorry this took so long to get merged!

@pablohoffman
Copy link
Member

@mgregson this broke tests, could you take a look?
https://travis-ci.org/scrapy/scrapyd/builds/28011871

@mgregson
Copy link
Contributor Author

@pablohoffman I'm not particularly familiar with travis-ci, but it looks to me (from reading the log at https://travis-ci.org/scrapy/scrapyd/jobs/28011872) like this failure is entirely unrelated to my patch. Nothing in the stack trace indicates that scrapyd was even running - the errors were emitted by pip. The messages of note seem to be:

error: [Errno 104] Connection reset by peer
Storing debug log for failure in /home/travis/.pip/pip.log
The command "pip install --use-mirrors -r .travis/requirements-$BUILDENV.txt" failed and exited with 2 during .

and

$ pip install --use-mirrors -r .travis/requirements-$BUILDENV.txt
--use-mirrors has been deprecated and will be removed in the future. Explicit uses of --index-url and/or --extra-index-url is suggested.

Since none of the other tests failed and the project dependencies presumably did not change between tests, I suspect that this was some random network error with either travis-ci or whatever host pip was trying to connect to. However, it seems appropriate to update your .travis.yml to remove the deprecated --use-mirrors option anyway, so perhaps do that and re-run the test suite?

@pablohoffman
Copy link
Member

@mgregson you were right, the Travis failure was completely unrelated to your change. Sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants