Performance improvement

[malloxpb]

This PR aims to improve the performance of SCURL

[codecov]

Codecov Report

Merging #42 into master will decrease coverage by 0.21%.
The diff coverage is 61.86%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   61.58%   61.37%   -0.22%     
==========================================
  Files           2        2              
  Lines         315      321       +6     
==========================================
+ Hits          194      197       +3     
- Misses        121      124       +3

Impacted Files	Coverage Δ
scurl/canonicalize.pyx	19.46% <12.5%> (-1.96%)	⬇️
scurl/cgurl.pyx	84.13% <74.46%> (+4.41%)	⬆️

[malloxpb]

Hey @lopuhin , in this PR, I have successfully increased the performance of urljoin and canonicalize_url by doing the folowing:

• Took care of the double parsing in urljoin
• Removed unnecessary to_native_str call in canonicalize_url since we know the types of variables
• made calls to our function canonicalize_component from chromium instead of calling quote from urllib.parse.

These have brought significant increase to the performance of canonicalize_url as well as urljoin. In particular, the rate of link extraction from canonicalize_url increased from 31k links/sec to 44k links/sec. But let me know if there's anything that concerns you :)

[malloxpb]

For some reason the cgurl.cpp is conflicted with the one from master branch...

[lopuhin]

@nctl144 the changes look good to me, nice job 👍
But the build failed, can you have a look?

[lopuhin]

Completely unrelated, but do you recall why we don't we use the same chromium urls here as well?

[lopuhin]

I'm curious how this works: we have cdef bytes bytes_str above and return it from the function, but return type of the function is char * - is this correct?

[lopuhin]

Never mind, looks like Cython indeed does this conversion automatically.

[malloxpb]

Hey @lopuhin , I have cleaned up the code even further by moving all the canonicalize code to canonocalize.pyx :) I think this PR is ready!

[lopuhin]

Hey @nctl144 the changes look good but the build is failing (for a different reason), can you have a look at it?

[malloxpb]

Hey @lopuhin , yeah sorry about that... I did not notice yesterday 😄 I just fixed it and the build is green now

[lopuhin]

Thanks @nctl144 , looks good! 👍