-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in safe_url_encoding #188
Comments
This is caused by #174, but I have no idea which line would do this. |
@wRAR I found why is this happening. The I could make a workaround I guess, but it would be an awful hack imo. Do you think it worth to change the behavior? |
Hmm I was afraid urllib does that, but I only tested To be honest I don't think we should work around this in the w3lib code but I'm open to suggestions. |
@azierariel I'm curious how have you found this issue - what does this change break for you? Why do you need to freeze w3lib to a previous version? |
@kmike I pass parameters to the download_handlers in scrapy. For example: captcha://file_path.png, here if the file path has any upper case it will be transformed to lower and my code will fail. |
That just looks like an invalid URI. You should put paths into the path section, not the host one. |
@azierariel Does it work if you use an extra |
@Gallaecio It works perfectly, thanks! I think I can close the issue right? |
Hi,
I hope I find you well.
I found the following issue, not sure if it's a bug, but it didn't behave like this in the previous version (1.22).
Before on 1.22.0:
But now on 2.0.1:
I understand that the domain is not case sensitive, but is this the desired behavior of the function?
Cheers,
The text was updated successfully, but these errors were encountered: