Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add griffpatch's developer tools #17

Closed
WorldLanguages opened this issue Jul 28, 2020 · 4 comments · Fixed by #86
Closed

Add griffpatch's developer tools #17

WorldLanguages opened this issue Jul 28, 2020 · 4 comments · Fixed by #86
Labels
new addon Related to new addons to this extension. `scope: addons` should still be added. scope: addon Related to one or multiple addons type: enhancement New feature for the project

Comments

@WorldLanguages
Copy link
Member

I think it does "weird" stuff by adding a trap to addEventListener. To avoid addons from interfering with each other, such traps should be handled by the addon handler and maybe we should provide a Scratch editor specific API.
@WorldLanguages WorldLanguages added the new addon Related to new addons to this extension. `scope: addons` should still be added. label Jul 28, 2020
@Explosion-Scratch
Copy link
Contributor

What do you mean by "wierd" stuff? =P

@WorldLanguages
Copy link
Member Author

@Explosion-Scratch It uses little side-effect hacks, it's probably the only way to make it work tho. The Scratch editor hasn't been made with browser extensions in mind.

@Explosion-Scratch
Copy link
Contributor

Oh, I see.

@WorldLanguages WorldLanguages mentioned this issue Aug 18, 2020
Closed
@WorldLanguages
Copy link
Member Author

Just looked, it doesn't do weird stuff with events. An old version did. That's nice :)

@WorldLanguages WorldLanguages changed the title Look at griffpatch's developer tools Add griffpatch's developer tools Aug 21, 2020
@WorldLanguages WorldLanguages mentioned this issue Aug 21, 2020
Merged
@Hans5958 Hans5958 added type: enhancement New feature for the project scope: addon Related to one or multiple addons labels Jan 15, 2021
RedGuy12 pushed a commit to RedGuy12/ScratchAddons that referenced this issue Oct 3, 2021
@williamhorning
Merge pull request ScratchAddons#17 from RedGuy12/release
96ca29d 
fetch after adding remote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new addon Related to new addons to this extension. `scope: addons` should still be added. scope: addon Related to one or multiple addons type: enhancement New feature for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add editor devtools by griffpatch WorldLanguages/ScratchAddons
3 participants
@Hans5958 @WorldLanguages @Explosion-Scratch