-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search sprites and sprites folder to not cooperate properly. #7298
Comments
It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer. |
At least on Windows, searching in a folder includes all subfolders. I think users will expect a similar behavior here. |
Yes, indeed we can search for subfolders in a folder... And we can search folders here? |
But then you have to, before your search, open all the folders you want to search in. I think it should always show folders if their name or a name of a sprite inside of them matches the search query, regardless of if they're opened or closed. |
My expectation here is that the add-on is supposed to know the existence of the sprites inside the closed folders. I am aware that the issue is caused by the folders being treated as sprites. The reason why we should be able to search for sprites inside closed folders is because that way, we can instantly locate the sprites without having to plow through the folders we have created. |
What about the following fix:
|
@iqnite Sounds reasonable. |
That's the way to go 😀 |
Is there a way to share info between addons? |
@iqnite In this case, I think ideally the folders addon should expose 2 functions: one that opens all folders, and a getter/setter for the state of which folders are open. |
For prototyping, it's okay to attach things to the global |
Last time I checked, |
Description
With the "search sprite" feature, I cannot search for sprites that are contained inside an unopened folder. Opened folders work as expected.
Steps to reproduce
1.Install the extension.
2.Enable both "Sprite folders" by GarboMuffin and "Search box in sprite pane" by BarelySmooth and GarboMuffin.
3.In a project, add some sprites into a folder and close the folder.
4.Search for the contained sprites.
Those sprites in the closed folder do not show up in the results.
Demonstration(s) and additional context
Unable to provide screenshots for now.
Environment
Google Chrome | 120.0.6099.200 (Official Build) (64-bit) (cohort: Stable Installs & Version Pins) -- | -- Revision | 4c400b5eade71f580ad9e320a2c4634dc5a0a0f9-refs/branch-heads/6099@{#1669} OS | Windows 10 Version 22H2 (Build 19045.3803) JavaScript | V8 12.0.267.14The text was updated successfully, but these errors were encountered: