Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor-dark-mode: URL color is handled weirdly #7354

Closed
OneShot-Niko opened this issue Apr 13, 2024 · 3 comments · Fixed by #7401
Closed

editor-dark-mode: URL color is handled weirdly #7354

OneShot-Niko opened this issue Apr 13, 2024 · 3 comments · Fixed by #7401
Assignees
Labels
scope: addon Related to one or multiple addons type: bug A bug in the addon loader, or in a specific addon

Comments

@OneShot-Niko
Copy link
Contributor

Description

editor-dark-mode can have a bit of issues with URLs

Steps to reproduce

  1. enable editor dark mode
  2. change settings a bit (see extra context for the settings i got this with)
  3. make a cloud variable

Demonstration(s) and additional context

For comparison, editor dark mode and normal:
editor darkmode

normal

Settings

"editor-dark-mode":{"enabled":false,"settings":{"page":"#222222ff","primary":"#593e91ff","highlightText":"#ffffffff","menuBar":"#6e4cb2ff","popup":"#855cd65c","activeTab":"#431c8eff","tab":"#040351ff","selector":"#070303ff","selector2":"#202020","selectorSelection":"#2c1c44ff","accent":"#1b1919ff","input":"#000000ff","workspace":"#070707ff","categoryMenu":"#202020","palette":"#202020cc","fullscreen":"#000000ff","stageHeader":"#000000ff","border":"#855cd666","dots":false,"affectPaper":true,"affectStage":true,"_version":10}}

Environment

Browser: Firefox 124.0.2 (32 bit)
Scratch Addons version: 3c9b881
Operating system: Windows 10

@OneShot-Niko OneShot-Niko added status: needs triage Needs triaging by putting relevant labels type: bug A bug in the addon loader, or in a specific addon labels Apr 13, 2024
@Samq64
Copy link
Member

Samq64 commented Apr 13, 2024

highlightText is set to white but the banner isn't dark like other backgrounds that use it.

@Samq64 Samq64 added scope: addon Related to one or multiple addons and removed status: needs triage Needs triaging by putting relevant labels labels Apr 13, 2024
@mxmou
Copy link
Member

mxmou commented Apr 13, 2024

Website dark mode changes messages like this to a darker shade of green:
image

Editor dark mode should probably do the same.

@WorldLanguages
Copy link
Member

Keywords for search: "cloud variables only supports numbers learn more"

@mxmou mxmou self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: addon Related to one or multiple addons type: bug A bug in the addon loader, or in a specific addon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants