Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image file metadata and the better-img-uploads addon #7380

Closed
WorldLanguages opened this issue Apr 24, 2024 · 5 comments · Fixed by #7506
Closed

Image file metadata and the better-img-uploads addon #7380

WorldLanguages opened this issue Apr 24, 2024 · 5 comments · Fixed by #7506
Labels
priority: 3 Medium priority. Includes bugs and useful features scope: addon Related to one or multiple addons
Milestone

Comments

@WorldLanguages
Copy link
Member

It has been reported through the feedback page that:

The HD image uploader does not remove information from the metadata of images. This can lead to geolocation data being preserved, which is a privacy risk.

If uploading the image normally through vanilla Scratch upload does cause the metadata to be removed for some reason, then we should consider changing our addon so that it's also removed.

@WorldLanguages WorldLanguages added the scope: addon Related to one or multiple addons label Apr 24, 2024
@DNin01
Copy link
Member

DNin01 commented Apr 24, 2024

I remember that metadata of audio files (artists, year, etc.) is preserved when uploaded into a project, and anyone can see it by exporting and downloading the audio track from the project. I haven't checked if the same applies to images or SVGs.

We can't really do anything if that is the case, other than maybe make an addon that omits metadata from all uploads?

@WorldLanguages
Copy link
Member Author

Can you check?

@DNin01
Copy link
Member

DNin01 commented Apr 24, 2024

Can you check?

I uploaded (normally) a JPEG image with an author and copyright specified and the metadata was not present in the exported file.

I was able to get the metadata by decoding the base64 of the image in the SVG file when uploading it with the HD uploads addon, so this issue can be confirmed.

@OneShot-Niko

This comment was marked as off-topic.

@BroJac5246
Copy link
Contributor

This seems dangerous, given that Scratch is targeted at kids. The priority should always be user safety, so I think we should fix this ASAP.

We could also consider adding a separate addon that removes metadata from sounds and maybe even existing images.

@WorldLanguages WorldLanguages added the priority: 3 Medium priority. Includes bugs and useful features label Apr 28, 2024
@WorldLanguages WorldLanguages added this to the v1.39.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 3 Medium priority. Includes bugs and useful features scope: addon Related to one or multiple addons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants