Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max list safe length too high in variable-manager #7398

Closed
valmontechno opened this issue May 1, 2024 · 2 comments
Closed

Max list safe length too high in variable-manager #7398

valmontechno opened this issue May 1, 2024 · 2 comments
Labels
scope: addon Related to one or multiple addons type: bug A bug in the addon loader, or in a specific addon

Comments

@valmontechno
Copy link
Contributor

Description

The variable-manager addon has a maximum length for the lists it can display.

maxSafeLength = 5000000;

However, this limit is higher than the natural scratch limit.

In Scratch 3.0, lists have a hard size limit of 200,000 items.

So the list too big value message can't be displayed.

Steps to reproduce

scrnli_01_05_2024.12-57-25.webm

Demonstration(s) and additional context

No response

Environment

Browser: Google Chrome 124.0.6367.63
Scratch Addons version: v1.37.1
Operating system: Windows 10

@valmontechno valmontechno added status: needs triage Needs triaging by putting relevant labels type: bug A bug in the addon loader, or in a specific addon labels May 1, 2024
@mxmou mxmou added scope: addon Related to one or multiple addons and removed status: needs triage Needs triaging by putting relevant labels labels May 1, 2024
@mxmou
Copy link
Member

mxmou commented May 1, 2024

maxSafeLength is the maximum length of the string representation of the list, not the maximum number of items.

@mxmou mxmou closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
@valmontechno
Copy link
Contributor Author

I understand, this is the maximum number of characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: addon Related to one or multiple addons type: bug A bug in the addon loader, or in a specific addon
Projects
None yet
Development

No branches or pull requests

2 participants