Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sharable URLs for querying data #122

Merged
merged 11 commits into from Mar 18, 2024
Merged

feat: sharable URLs for querying data #122

merged 11 commits into from Mar 18, 2024

Conversation

mehulmathur16
Copy link
Contributor

/claim #116
/fixes #116

48b664f4-df9a-4614-a9fd-1b37160f6f1c.mp4

@algora-pbc algora-pbc bot mentioned this pull request Mar 16, 2024
Closed
11 tasks
@mehulmathur16
Copy link
Contributor Author

Hi @poundifdef, can you please review this PR. I have attached a screen recording of the feature for your reference.

@mehulmathur16 mehulmathur16 changed the title feat: share query APIs feat: sharable URLs for querying data Mar 16, 2024
poundifdef
poundifdef requested changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@poundifdef poundifdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks good, just a few small changes.

pkg/api/api.go Outdated Show resolved Hide resolved
pkg/api/api.go Outdated Show resolved Hide resolved
pkg/api/api.go Outdated Show resolved Hide resolved
pkg/api/api.go Outdated Show resolved Hide resolved
pkg/api/api.go Outdated Show resolved Hide resolved
pkg/api/api.go Outdated Show resolved Hide resolved
pkg/storage/cache/cache.go Show resolved Hide resolved
@mehulmathur16
Copy link
Contributor Author

@poundifdef I've resolved the comments except the cache pkg. I need more clarity on it.

Also, Can you please assign me this issue ?

poundifdef
poundifdef reviewed Mar 16, 2024
View reviewed changes
pkg/api/api.go Outdated Show resolved Hide resolved
@mehulmathur16
Copy link
Contributor Author

@poundifdef I have added the cache pkg. Please review once.

poundifdef
poundifdef requested changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@poundifdef poundifdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just one small change and then I'll merge. Thank you!

pkg/api/api.go Outdated Show resolved Hide resolved
@mehulmathur16
Copy link
Contributor Author

Hi @poundifdef, I have made the requested changes. Please review.

poundifdef
poundifdef reviewed Mar 18, 2024
View reviewed changes
pkg/api/api.go Outdated Show resolved Hide resolved
@mehulmathur16
Copy link
Contributor Author

Hi @poundifdef, please review.

@poundifdef
Copy link
Contributor

This looks good. Thank you.

@poundifdef poundifdef merged commit 421d0c0 into scratchdata:main Mar 18, 2024
@mehulmathur16
Copy link
Contributor Author

This looks good. Thank you.

That's great! Thankyou for the opportunity.
Looking forward for more contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poundifdef poundifdef poundifdef approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharable URLs for Querying Data
2 participants
@mehulmathur16 @poundifdef