feat: use aws secret manager #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
poundifdef
requested changes
Mar 19, 2024
There was a problem hiding this comment.
This code does not compile. Can you show a recording of the software working after you've fixed it? Then I'll review again.
To test, run:
go run .
And then
curl -G "http://localhost:8080/api/data/query" \
--data-urlencode="api_key=local" \
--data-urlencode="query=select 1"
This should not throw any errors on the go side and the curl command. should return regular JSON.
| @@ -66,7 +66,7 @@ func setupLogs(logConfig config.Logging) { | |||
| } | |||
| } | |||
|
|
|||
| func GetStorageServices(c config.ScratchDataConfig) (*models.StorageServices, error) { | |||
| func GetStorageServices(c config.ScratchDataConfig, vault vault.Vault) (*models.StorageServices, error) { | |||
There was a problem hiding this comment.
Do not change the signature of this function. Instead, add a new Vault member to the models.StorageServices struct. You can follow the same pattern we use for the blobstore and queue in this function.
| ) | ||
|
|
||
| type Database interface { | ||
| VerifyAdminAPIKey(hashedAPIKey string) bool | ||
|
|
||
| GetDestinations() []config.Destination | ||
| CreateDestination(destType string, settings map[string]any) (config.Destination, error) | ||
| GetDestinationCredentials(dbID int64) (config.Destination, error) | ||
| GetStorageServices() []config.StorageService |
There was a problem hiding this comment.
This is not needed. When creating a database, we already pass the StorageServices struct into the New... function.
|
Because this code doesn’t compile, I will close this pr for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
/claim #126