-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Connection URL #150
Remote Connection URL #150
Conversation
…hris/scratchdata into credential-share-link-147
Overall - I am able to get it to work! Yay! Some comments:
In an ideal world, the end user would be able to also choose their database type, instead of a link being specific to duckdb. However, we can table that for now. I'm fine with merging this and then making tickets for the above issues and tackling them on another iteration, since i know you've already started on the other feature. |
} | ||
|
||
http.Redirect(w, r, "/dashboard/request/success", http.StatusFound) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an edge case where the user hits the back button, then they end up on this page. However it correctly throws an error saying "connection request not found" so i think we can ignore that for now.
A user should be able to create a URL to share with someone they wish to send data to.
For example, Customer A uses scratchdata and Customer B is a customer of Customer A. Customer B has a Big Query instance and would like to get data from Customer A pushed to them. Customer A would create a Remote Connection URL and share it with Customer B. Customer B enters in their connection information for Big Query, saves it, and it is now accessible to Customer A to start sending data to it.
#147