All destinations #152
Merged
All destinations #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hris/scratchdata into credential-share-link-147
…tinations-151 # Conflicts: # pkg/view/router.go # pkg/view/templates/pages/connections/upsert.html
…estinations-151 # Conflicts: # pkg/view/templates/pages/connections/upsert.html
…estinations-151 # Conflicts: # pkg/view/templates/pages/connections/upsert.html
poundifdef
reviewed
Apr 5, 2024
…scratchdata into all-destinations-151
|
The error state of the form (invalid credential) does not work. |
|
The "request a connection" UI does not work. |
|
When I request a connection, the request is always set to DuckDB no matter what database type I choose. |
poundifdef
reviewed
Apr 9, 2024
…scratchdata into all-destinations-151
|
Awesome. This looks great, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#151
This generalizes how the destinations are configured: