Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor router.go #156

Merged
merged 8 commits into from Apr 15, 2024
Merged

refactor router.go #156

merged 8 commits into from Apr 15, 2024

Conversation

breadchris
Copy link
Contributor

@breadchris breadchris commented Apr 10, 2024 •
edited

This is involved, made sure testing all paths was done:

- testing
	- edit connection
		- new api key
		- delete
	- connect database
		- duckdb
		- clickhouse
			- couldn't verify it worked
		- redshift
		- bigquery
			- error when inserting data, noted in slack
		- test inserting data via api and querying
	- request connection
		- http://localhost:8080/dashboard/request/9b3495a4-ee7c-43b9-912c-a577efbf8237 -> unauth session
		- intentionally error
		- success
        - data sharing
	    - download

@breadchris breadchris changed the title reactor router.go refactor router.go Apr 13, 2024
@breadchris breadchris marked this pull request as ready for review April 13, 2024 01:23
poundifdef
poundifdef reviewed Apr 14, 2024
View reviewed changes
pkg/view/controller.go
}

func (s *Controller) upsertRequestFromForm(w http.ResponseWriter, r *http.Request) (*connections.ConnUpsertRequest, error) {
_, err := s.session.GetFlashes(w, r)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

pkg/view/controller.go
return nil, err
}

settings := map[string]any{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this stanza do?

@poundifdef poundifdef merged commit 6fdbc1e into scratchdata:main Apr 15, 2024
@breadchris
Copy link
Contributor Author

closes #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poundifdef poundifdef poundifdef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breadchris @poundifdef